RadioControl: Convert component to TypeScript #41568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
added
[Type] Enhancement
|
Size Change: -11 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Nice work @walbo 👍
This is all testing well for me.
✅ No typing errors
✅ Works in Storybook
✅ Works in editors
✅ Readme aligns with types
LGTM 🚢
ciampo
reviewed
Jun 9, 2022
Comment on lines
+48
to
+51
| props: Omit< | ||
| WordPressComponentProps< RadioControlProps, 'input', false >, | ||
| 'ref' | ||
| > |
There was a problem hiding this comment.
A bit late to the party, but I was curious about why it was necessary to omit ref ? Was it causing any errors ?
There was a problem hiding this comment.
Opened #41641 to add ref forwarding support
There was a problem hiding this comment.
👍
Didn't want to add any runtime changes.
There was a problem hiding this comment.
Sounds good, and I agree that it's a good rationale! I was mostly curious to know in case it caused any type errors :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Converts the
RadioControlcomponent to TypeScript.Why?
Part of the @wordpress/components's TypeScript migration (#35744).
How?
Refactors the current
RadioControlto TypeScript.Testing Instructions
RadioControlcontinues to function as expected